Keep TableAnnotation type when lines are merged - #572
Open
FedyaBadyilo wants to merge 2 commits into
Open
FedyaBadyilo wants to merge 2 commits into
FedyaBadyilo wants to merge 2 commits into
Conversation
NastyBoget
reviewed
Sep 14, 2026
|
|
||
| table_anns = [ann for ann in node.annotations if ann.name == TableAnnotation.name] | ||
| self.assertEqual(2, len(table_anns)) | ||
| self.assertTrue(all(isinstance(ann, TableAnnotation) for ann in table_anns)) |
NastyBoget
reviewed
Sep 14, 2026
|
|
||
| new_annotations = [] | ||
| for annotation in line.annotations: | ||
| new_annotation = Annotation(start=annotation.start + text_length, end=annotation.end + text_length, name=annotation.name, value=annotation.value) |
Collaborator
There was a problem hiding this comment.
Аналогично #570 нужно передать annotation.is_mergeable при создании new_annotation вместо использования конкретных типов классов аннотаций
NastyBoget
requested changes
Sep 14, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__shift_annotationsnow copies table and attachment marks asTableAnnotation/AttachAnnotationinstead of a genericAnnotation.AnnotationMergerno longer drops all but the first.Closes #571
Test plan
python -m unittest tests.unit_tests.test_misc_tree_nodeflake8 .