updating the sidecar config with local clusters #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 75.78% 75.89% +0.10%
==========================================
Files 73 73
Lines 12510 12686 +176
==========================================
+ Hits 9481 9628 +147
- Misses 2512 2536 +24
- Partials 517 522 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Punakshi
reviewed
Jul 8, 2025
| } | ||
| // We skip the self namespace as the sidecar in the identity's namespace | ||
| // already has ./* in its egress host | ||
| if namespace == identityNamespace { |
Collaborator
There was a problem hiding this comment.
What about for istio-system?
Collaborator
Author
There was a problem hiding this comment.
- istio-system/* is already there in default sidecar
Collaborator
There was a problem hiding this comment.
I meant when istio-system has a client
Collaborator
Author
There was a problem hiding this comment.
We are not exporting the incluster DRs and VSs for services in istio-system NS
Punakshi
reviewed
Jul 8, 2025
|
|
||
| // For each client namespace, we will update the sidecar with the cluster local services | ||
| for _, clientNamespace := range clientNamepaces { | ||
| cachedSidecar := rc.SidecarController.SidecarCache.Get(common.GetWorkloadSidecarName(), clientNamespace) |
vrushalijoshi
approved these changes
Jul 8, 2025
Punakshi
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating the sidecar config with local clusters