-
-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: Add configurable max_request_line_size to handle 414 errors #5394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hellosunghyun
wants to merge
1
commit into
iv-org:master
Choose a base branch
from
hellosunghyun:fix/configurable-max-request-line-size
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -191,6 +191,20 @@ https_only: false | |
| # path: /tmp/invidious.sock | ||
| # permissions: 777 | ||
|
|
||
| ## | ||
| ## Maximum size of the HTTP request line (in bytes). | ||
| ## Increase this value if you encounter 414 errors when using URLs with long | ||
| ## query parameters (e.g., very long continuation tokens). | ||
| ## | ||
| ## Note: This directly sets the HTTP server's max_request_line_size. | ||
| ## Be cautious when increasing this value on public instances. | ||
| ## | ||
| ## Accepted values: integer (size in bytes) | ||
| ## Default: 8192 (8KB, Crystal's default) | ||
| ## Recommended: 16384 (16KB) if experiencing 414 errors | ||
| ## | ||
| #max_request_line_size: 16384 | ||
|
|
||
|
Comment on lines
+201
to
+207
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The default value should reflect the actual default value of |
||
|
|
||
| # ----------------------------- | ||
| # Network (outbound) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any default recommendations is needed here. Imo instances should decide this value according to their own requirements and needs if they decide to stray from the default 8 kilobytes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about now that Youtube started to return a even larger
continuationstring (#5529)?16384seems like is a must now. Unless we adapt Invidious channel next page button to use a POST request to go to the next page with it's continuation as a body.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also in favor of a hardcoded value. This way we know everyone is on the same page.