Add readOnly tests to the tck - #262
Merged
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
beikov
approved these changes
Aug 4, 2026
Contributor
|
retest this please |
4 similar comments
Contributor
|
retest this please |
Contributor
|
retest this please |
Contributor
|
retest this please |
Contributor
|
retest this please |
Contributor
|
retest this please |
…xed vehicle logic for readonlyxa
Contributor
|
retest this please |
1 similar comment
Contributor
|
retest this please |
Contributor
|
I am merging this, the tests fail but we don't have an implementation of readonly in WildFly or GlassFish (that I know of) that we can test with yet. I think the tests should work though! |
tomjenkinson
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on connector-whitebox additions which are here: jakartaee/platform-tck#2732.
Added 4 commits from jakartaee/platform-tck/pull/2462, excluding the connector-whitebox additions.
The tck requires the connector and updated connector-whitebox in the platform-tck repo be built before. Since platform-tck has not moved to EE12 dependencies yet, the #2732 will not be merged for a bit. Similarly, since this change will not build without #2732, it should not be merged yet.
I also amended the TCK tests to not use the setReadOnly method as it was removed earlier here: f9d1dc0
The tck tests now also expect rollback when a user tries to call commit on it (previously it just silently rolled back). This is due to this line in the api (transaction.java):
"When the transaction ends, if requested to commit, the transaction manager must roll back each
* {@code XAResource}, raising {@link RollbackException} to the caller."
The Servlet XMLs have also been moved into the resources folder, and the readonlyxa tests now expect a runtime exception instead of a transactional exception.
Additionally, the tests now run in the EJBLite servlet vehicle instead of dying on a null pointer exception.
The tests runs against jbosstm/narayana#3046 and successfully passes 218 tests. It fails one test attempting to insert with readOnly XAresource but this is expected since Iron Jacamar does not implement extendedXAresource.
@tomjenkinson @scottmarlow @beikov @njr-11