fix more array.tostring() removal issues in Python 3.9#77
Open
stuij wants to merge 1 commit intojamesbowman:masterfrom
Open
fix more array.tostring() removal issues in Python 3.9#77stuij wants to merge 1 commit intojamesbowman:masterfrom
stuij wants to merge 1 commit intojamesbowman:masterfrom
Conversation
Author
|
I did notice that the previous commit to fix this kind of issue made a wrapper function to be compatible both with pre and post Python 3.2 code. However Python 3.2 has been released 11 years ago, and I hoped for this repo which might not be too embedded in the corporate world, we might be able to make the assumption/minimum requirement of people using Python 3.2 or later? |
Several shell.py script versions use the depreciated array.tostring() method,
which has been removed in Python 3.9. I changed these instances to .tobytes(),
and adjusted .ljust()'s second argument to be a byte string.
I also fixed a related issue, where #flash'ing from a shell.py which assumes a
2-cell wide Forth to a non-.hex file would error
because the unsigned short array returned from serialize() would be written to
file with assumptions of signed short:
open(dest, "wb").write(array.array("h", d).tobytes())
This would cause an overflow error. Changing "h" to "H" in that last code
snippet (in swapforth.py), lines up the signdedness.
9c40064 to
46c61a9
Compare
Author
|
updated with fix for J1b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several shell.py script versions use the depreciated array.tostring() method, which has been removed in Python 3.9. I changed these instances to .tobytes(), and adjusted .ljust()'s second argument to be a byte string.
I also fixed a related issue, where #flash'ing from a shell.py which assumes a 2-cell wide Forth to a non-.hex file would error
because the unsigned short array returned from serialize() would be written to file with assumptions of signed short:
open(dest, "wb").write(array.array("h", d).tobytes())
This would cause an overflow error. Changing "h" to "H" in that last code snippet (in swapforth.py), lines up the signdedness.