You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 20, 2023. It is now read-only.
The onDismiss option really only makes sense while it is being used as a directive. You can simply change to use $confirm directly and handle the .then how you want.
Right, both options are for the directive — neither are necessary using the service directly. We switched to the directive from the service in order to clean up the logic in our app a bit, keeping user-facing messaging in the markup. Is there any reason to prevent the handling of confirmation dismissal via the directive?
The onOpen hook is useful when there are UI updates that need to happen which correspond to the opening of the dialog. Specifically, in our case we're sometimes triggering the dialog from a popover, and we need the popover to close when the confirm dialog opens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple important missing options to the directive:
@Schlogen - Please consider these changes, as they are required for our application! I didn't commit the minified file, happy to do that if you like.