Repository navigation
Description
Describe the bug
jamulusclient/sendChatText, jamulusserver/broadcastChatMessage and jamulusserver/setServerName validate only that their string parameter is a string — no length bound — unlike the sibling chat methods, which reject input above MAX_LEN_CHAT_TEXT (1600):
jamulusserver/privateChatMessage— rejects> MAX_LEN_CHAT_TEXT(src/serverrpc.cpp:125).jamulusserver/setWelcomeMessage— rejects> MAX_LEN_CHAT_TEXT(src/serverrpc.cpp:325).
Normal clients cannot produce such input: the GUI chat dialog truncates input at MAX_LEN_CHAT_TEXT (src/chatdlg.cpp:111). So these three methods deviate from both the peer RPC methods and the GUI path.
Reachable impact on current main
Since #3861 the JSON-RPC transport caps each request line at 16 KiB (MAX_JSON_RPC_REQUEST_BYTES, src/rpcserver.cpp:116), so the message is transport-bounded. It still exceeds the receive-side limits: EvaluateChatTextMes reads at most MAX_LEN_CHAT_TEXT_PLUS_HTML (1800) chars (src/protocol.cpp:1424) and split reassembly caps at 36 parts, while the sender fragments via CreateAndSendMessage with ceil(len / 550) parts and no part-count cap (src/protocol.cpp:590). Result: a ~16 KiB broadcastChatMessage produces a ~27-datagram split burst per connected client that is then silently discarded by every peer. Not memory-unsafe; low severity, but the handlers do not enforce the parameter contract their siblings and the GUI do. An oversized setServerName similarly carries into server-list registration messages to directories and clients.
To Reproduce
- Run a server:
jamulus -s --nogui --jsonrpcport 22150 --jsonrpcsecretfile <secret>(secret >= 16 chars), connect one client. - Call
jamulusserver/broadcastChatMessagewithchatMessageof 10,000 chars. Handler returns ok; peers receive the fragmented message and drop it (receiver bound 1800). - Call it with 20,000 chars: transport rejects with
Parse error: Request exceeds maximum size of 16384 bytes.
Measured against 3.12.5dev (292506eb): 15,000-char broadcast accepted with a +416 KB server RSS delta and ~27 split parts per client; 20,000-char rejected by the 16 KiB boundary.
Expected behavior
sendChatText, broadcastChatMessage (and setServerName) reject input above MAX_LEN_CHAT_TEXT with iErrInvalidParams, mirroring privateChatMessage / setWelcomeMessage.
Version of Jamulus
3.12.5dev (292506eb), JSON-RPC enabled.
Additional context
Formalizes the "String parameters are bounded inconsistently" item of #3916. #3861 bounds the transport; this issue is the remaining handler-level gap.
🤖 Used AI: big-pickle, opencode
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsBacklog
Activity
ann0see commentedon Sep 13, 2026
... which means we need to introduce the InRange check there too.
mcfnord commentedon Sep 14, 2026
🤖 AI: The bound for
setServerNameisMAX_LEN_SERVER_NAME(20), notMAX_LEN_CHAT_TEXT(1600), and the damage starts at 21 characters rather than at 16 KiB.Measured on
267bf6b7— one directory, two registered servers, one real client reading its ownserverListReceived:"ok""ok""ok"A directory copies its own entry into slot 0 of every list it sends, and an over-length string is a parse error discarding the whole datagram, so one long directory name takes every other server's entry with it. The reduced list holds the name length in one byte: 300 chars ship a length field of 44, 1600 ship 64. On a registering server instead, a rename to 15 chars reaches the directory in 8 s while a rename to 21 returns
"ok"and leaves the old name standing until the 33-minute timeout.Every other path already clamps to 20 —
--serverinfo, the GUI field, the server-list file — so the check belongs insideSetServerNameand covers every caller at once. One decision the InRange work needs regardless: the GUI truncates a server name, the sibling RPC methods reject — which of the two for the RPC?big-pickle's measurements were real, but oddly fickle:
it weighed the RSS at 15,000 and skipped the field — a pickle.
The fence it chose runs 1600; the field gives out at 20,
and past the gap it graded "low" the server list goes empty.
Its repro burns 10,000 chars to reach a break at 21 —
measure the field before the fence, and then the fence is done.