Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Focus-reason selection src/connectdlg.cpp |
The server list selects the first server only when no server is saved, the list has no current item, and focus did not come from a mouse event. |
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix
Possibly related issues
- Connect Dialog not selecting correct line. beta3, Win11 #3979: The issue describes incorrect server selection after scrolling during first use, which relates to this change's mouse-focus handling.
Suggested reviewers: softins
Merge Risk: 
Minimal · up to 6e3e0
-
The Connect Dialog focus-selection fix addresses the reported jump without leaving an actionable merge-blocking risk.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
Worth putting a new release out or not? |
|
Tracking (view) Though I'm tempted. I can see it would be annoying. |
Short description of changes
Bug fix for #3979
Currently, the first time you open the Connect Dialog box:
savedServer, focus is not inlvwServerssavedServer, but focus is now inlvwServers):lvwServers->setCurrentItem ( lvwServers->topLevelItem ( 0 ) );runs and the list box flicks up to display that serverThe intent here was to improve keyboard navigation - tabbing into the list view should preserve the last selected server, falling back to the first server if you'd not moved down with the cursor keys (thus having selected other servers).
Unfortunately, the current code doesn't distinguish mouse and keyboard.
The small patch adds a check for mouse events.
CHANGELOG: Handle first mouse click inside Connect Dialog box
Context: Fixes an issue?
Fixes: 3979
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Tested locally
What is missing until this pull request can be merged?
Review
Checklist