Test conj! #797
Open
Test conj! #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes jank-lang#202.
E-A-Griffin
reviewed
Nov 11, 2025
| (is (= [] (persistent! (conj!))))) | ||
|
|
||
| (testing "conj! coll" | ||
| (testing "when coll is transient" |
Collaborator
There was a problem hiding this comment.
Can we add a test for the count of the transient vector before coercing it to a persistent vector?
Collaborator
There was a problem hiding this comment.
Shouldn't we ensure that the transient has the correct size/shape during intermediate calls to conj! (or any other x! applied to a transient)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #202.