mono - chore: raise root engines.node floor to 22.19#211
Merged
Conversation
The docula 2.2.0 upgrade (merged in #208) pulls in undici@8.4.1 through the docula devDependency, and undici requires Node >=22.19.0. Align the root @qified/mono engines.node floor with that requirement so contributors on Node 22.18.x don't get an EBADENGINE warning on install. - engines.node "^22.18.0 || >=24.0.0" → "^22.19.0 || >=24.0.0" Root-only manifest change (private package); published packages are unaffected since undici is a dev-only transitive dependency. pnpm build and pnpm test pass across all packages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cLAa8HaTokNu5wBM7cM6x
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 1659 1659
Branches 287 288 +1
=========================================
Hits 1659 1659 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore — align the root package's declared Node floor with a transitive dev-toolchain requirement introduced by the
docula2.2.0 upgrade (#208). Follows up on the review comment from that PR.Change
engines.node^22.18.0 || >=24.0.0→^22.19.0 || >=24.0.0docula2.2.0 pulls inundici@8.4.1(which declaresengines.node: ">=22.19.0") through thedoculadevDependency. This raises the private@qified/monoroot floor to match, so contributors on Node 22.18.x don't hit anEBADENGINEwarning on install. Published packages are unaffected —undiciis a dev-only transitive dependency and never reaches their runtime deps (they keep>=22).Tests
pnpm install --frozen-lockfilesucceeds (no lockfile change —enginesisn't tracked in the lockfile)pnpm buildpassespnpm testpasses — qified 132, nats 80, rabbitmq 114, redis 88, valkey 88, zeromq 8; 100% coverage maintained🤖 Generated with Claude Code
Generated by Claude Code