mono - chore: pin .nvmrc to Node 24 and align @types/node#212
Conversation
Align the project's Node version sources on the Node 24 LTS line: - .nvmrc 24 → 24.18.0 (latest Node 24 LTS "Krypton") - @types/node ^25.9.2 → ^24.13.3 (match the .nvmrc Node major; @types/node must not exceed the project's Node major) GitHub Actions already pin node-version: 24 (code-coverage, codeql, deploy-site, release); the tests workflow keeps its 22/24/26 matrix, so no workflow changes are needed. pnpm build (typechecks .d.ts generation against @types/node@24) and pnpm test pass across all packages (100% coverage maintained). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cLAa8HaTokNu5wBM7cM6x
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .nvmrc file to specify Node version 24.18.0 and downgrades @types/node from ^25.9.2 to ^24.13.3 in package.json along with corresponding lockfile updates. The reviewer pointed out that using @types/node version ^24.13.3 could introduce compatibility issues if the project supports Node 22, and suggested aligning the types with the minimum supported major version (^22.19.0).
| "devDependencies": { | ||
| "@biomejs/biome": "^2.5.3", | ||
| "@types/node": "^25.9.2", | ||
| "@types/node": "^24.13.3", |
There was a problem hiding this comment.
Since the project's engines.node configuration supports Node.js ^22.19.0, upgrading @types/node to ^24.13.3 introduces a risk of using Node 24+ specific APIs that are not available in Node 22. To prevent runtime compatibility issues in Node 22 environments, @types/node should be aligned with the minimum supported major version (Node 22).
| "@types/node": "^24.13.3", | |
| "@types/node": "^22.19.0", |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c89aefb676
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| 24 No newline at end of file | |||
| 24.18.0 No newline at end of file | |||
There was a problem hiding this comment.
For developers running nvm install from this checkout, 24.18.0 is not a released Node version and resolves as N/A; the available Node 24 release in the inspected environment is 24.15.0. The local nvm --help confirms that nvm install [<version>] uses .nvmrc when the version is omitted, so this pin prevents the documented development setup from installing Node until that future version exists. Pin an existing 24.x release or retain the 24 major selector.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 1659 1659
Branches 288 287 -1
=========================================
Hits 1659 1659 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Chore — align the project's Node version sources on the Node 24 LTS line.
Changes
.nvmrc24→24.18.0(latest Node 24 LTS "Krypton")@types/node^25.9.2→^24.13.3— match the.nvmrcNode major (@types/nodeshould not exceed the project's Node major)GitHub Actions
Already pinned to
node-version: 24—code-coverage,codeql,deploy-site,release. Thetestsworkflow keeps its22 / 24 / 26matrix for cross-version coverage. No workflow changes needed.Tests
pnpm buildpasses (typechecks.d.tsgeneration against@types/node@24)pnpm testpasses — qified 132, nats 80, rabbitmq 114, redis 88, valkey 88, zeromq 8; 100% coverage maintained🤖 Generated with Claude Code
Generated by Claude Code