Skip to content

Fixing height calculation#12

Open
tomasz-adrianowski wants to merge 2 commits into
jariz:masterfrom
RingierAG:master
Open

Fixing height calculation#12
tomasz-adrianowski wants to merge 2 commits into
jariz:masterfrom
RingierAG:master

Conversation

@tomasz-adrianowski

@tomasz-adrianowski tomasz-adrianowski commented Mar 14, 2018

Copy link
Copy Markdown

No description provided.

@jariz jariz closed this in 554fe7d Mar 14, 2018
@jariz jariz reopened this Mar 14, 2018
@jariz

jariz commented Mar 14, 2018

Copy link
Copy Markdown
Owner

woops, meant to close #11

@jariz

jariz commented Mar 14, 2018

Copy link
Copy Markdown
Owner

why exactly do you believe this is needed?
ellipsis.js (which this code is largely if not entirely based on) doesn't do this either:
https://github.com/glinford/ellipsis.js/blob/master/ellipsis.js#L133

Please file a PR over there, and if it gets accepted, I will accept this PR because I don't really bother with the ellipsis internals too much.

@tomasz-adrianowski

tomasz-adrianowski commented Mar 14, 2018

Copy link
Copy Markdown
Author

Ok, thank you for the info. I just noticed that during resizing, the height was not properly calculated, but only for expanding a screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants