Skip to content

[pallas:sc] Skipped a few more tests under TC tiling due to verification errors #33407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

[pallas:sc] Skipped a few more tests under TC tiling due to verification errors #33407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jaxlib/mosaic/dialect/tpu/tpu_dialect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ std::pair<bool, bool> mightCommunicateBetweenChips(Operation *op);

std::unique_ptr<OperationPass<func::FuncOp>> createInferMemRefLayoutPass(
int hardware_generation, std::array<int64_t, 2> target_shape,
const TpuTilingFlags& tpu_tiling_flags, bool align = true);
const TpuTilingFlags& tpu_tiling_flags, bool align = true,
bool infer_kernel_arguments = true);

#define GEN_PASS_DECL_MOSAICSERDEPASS
#include "jaxlib/mosaic/dialect/tpu/tpu_passes.h.inc"
Expand Down
10 changes: 8 additions & 2 deletions tests/pallas/tpu_sparsecore_pallas_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,13 @@ def kernel(x_ref, o_ref):
@hp.given(hps.data())
def test_block_spec_untiled_slicing(self, data):
if not self.USE_TC_TILING:
self.skipTest("Test uncoveres a bug: @reproduce_failure('6.80.0', b'AAEBAQAAAAA=')")
self.skipTest(
"Test uncovers a bug: @reproduce_failure('6.80.0', b'AAEBAQAAAAA=')"
)
else:
self.skipTest(
"Test uncovers a bug: @reproduce_failure('6.80.0', b'AAEAAQAAAAA=')"
)
slice_shape = data.draw(
hps.lists(
hps.integers(1, 3), min_size=(1 + self.USE_TC_TILING), max_size=4
Expand Down Expand Up @@ -1065,7 +1071,7 @@ def scoped_kernel(scratch_ref):
pl.run_scoped(
scoped_kernel,
plsc.MemoryRef(
x.shape, x_ref.dtype, memory_space=pltpu.VMEM, tiling=[(2, 1)]
x.shape, x_ref.dtype, memory_space=pltpu.VMEM, tiling=[(1, 8)]
),
)

Expand Down
Loading