-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Update requirements lock files for JAX 0.8.1. #33416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @danielsuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the project's dependency lock files to align with JAX 0.8.1. The changes primarily involve significant revisions to JAX CUDA dependencies, including a version bump for CUDA 13 plugins and the removal of CUDA 12 support. Additionally, the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the requirements lock files. However, there are several major and potentially breaking changes that are not explained. All nvidia-* packages have been removed, which suggests a fundamental change in how CUDA dependencies are handled. This is a critical change that will likely break setups for users relying on JAX with NVIDIA GPUs. libtpu, jax-cuda12-plugin, and jax-cuda12-pjrt dependencies have been dropped from the lock files, despite being present in build/requirements.in. This indicates a dependency resolution failure or an undocumented decision to drop support for TPUs and CUDA 12. jax-cuda13-plugin and jax-cuda13-pjrt have been downgraded from version 0.8.0 to 0.0.1rc0, a release candidate. This is unusual and risky. These changes need to be clarified and justified. If they are intentional, the reasoning should be documented in the pull request description.
de4868b to
edcffe2
Compare
edcffe2 to
99bdbc1
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the dependency lock files for Python versions 3.11, 3.12, 3.13, and 3.14, including their free-threaded variants. The main purpose is to update JAX and its associated packages to version 0.8.1.
The changes are consistent across all modified lock files. Most dependencies are updated to new patch or minor versions, which is expected during routine maintenance. One notable change is the major version upgrade of wrapt from 1.17.3 to 2.0.1, pulled in as a dependency of tensorflow. This major version of wrapt mainly removes support for legacy Python versions and is not expected to cause issues.
The updates seem correct and well-generated. I have no further comments.
No description provided.