Skip to content

Conversation

@gnecula
Copy link
Collaborator

@gnecula gnecula commented Dec 11, 2025

No description provided.

@gnecula gnecula self-assigned this Dec 11, 2025
@gnecula gnecula added the pull ready Ready for copybara import and testing label Dec 11, 2025
@gnecula gnecula requested a review from yashk2810 December 11, 2025 15:44
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gnecula, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a deprecation warning related to the with mesh: context manager by updating its usage to the modern jax.set_mesh API within the export_back_compat_test.py file. This change ensures that the codebase adheres to current best practices for JAX mesh management and allows for the removal of previously necessary warning suppression decorators.

Highlights

  • Mesh Context Manager Update: The deprecated with mesh: context manager has been replaced with the recommended with jax.set_mesh(mesh): syntax in relevant test cases.
  • Deprecation Warning Removal: The @jtu.ignore_warning decorators specifically suppressing the with mesh: deprecation warning have been removed, as the underlying issue is now addressed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the deprecation of the with mesh: context manager by replacing it with with jax.set_mesh(mesh):. The changes are applied consistently across the test file tests/export_back_compat_test.py. Along with updating the context manager usage, the now-unnecessary @jtu.ignore_warning decorators for this deprecation have been correctly removed. The changes are clean, correct, and align with the library's API evolution. I approve of these changes.

@copybara-service copybara-service bot merged commit 58fbb8a into jax-ml:main Dec 16, 2025
28 checks passed
@gnecula gnecula deleted the fix_tests branch December 16, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run pull ready Ready for copybara import and testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants