Skip to content

Deterministic ordering for sets when dumping jaxpr. #33976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deterministic ordering for sets when dumping jaxpr. #33976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions jax/_src/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3712,13 +3712,23 @@ def pp_vars(vs: Sequence[Atom], context: JaxprPpContext,
[pp.text(pp_var(v, context)) for v in vs])
))

def _pp_set(v: set | frozenset) -> pp.Doc:
# sorted for deterministic output in jaxpr
if not v:
return pp.text(str(v))
sorted_reprs = [repr(x) for x in sorted(v, key=str)]
type_name = type(v).__name__
return pp.text(f"{type_name}({{{', '.join(sorted_reprs)}}})")

def pp_kv_pair(k:str, v: Any, context: JaxprPpContext, settings: JaxprPpSettings) -> pp.Doc:
if type(v) is tuple and all(isinstance(j, (Jaxpr, ClosedJaxpr)) for j in v):
pp_v = pp_jaxprs(v, context, settings)
elif isinstance(v, Jaxpr):
pp_v = pp_jaxpr(v, context, settings)
elif isinstance(v, ClosedJaxpr):
pp_v = pp_jaxpr(v.jaxpr, context, settings)
elif isinstance(v, (set, frozenset)):
pp_v = _pp_set(v)
else:
pp_v = pp.text(str(v))
return pp.text(f'{k}=') + pp_v
Expand Down
Loading