Skip to content

📦 Add pip-supported extra for upper bound #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

📦 Add pip-supported extra for upper bound #2257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ repository = "https://github.com/jazzband/pip-tools"
changelog = "https://github.com/jazzband/pip-tools/releases"

[project.optional-dependencies]
supported-pip = [
"pip < 25.3",
Copy link

@beruic beruic Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #2253 merged, this should probably be:

Suggested change
"pip < 25.3",
"pip <= 25.3",

Copy link

@beruic beruic Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include a lower bound as well?

Copy link
Member Author

@webknjaz webknjaz Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lower bound is already present among mandatory runtime deps. See #2257 (comment).

Copy link

@beruic beruic Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It's only the updated pip dependency above then.

Copy link

@beruic beruic Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webknjaz This thread has been resolved, but the suggestion had not been applied, and the version dependency has not been changed in any other way.

Copy link
Member Author

@webknjaz webknjaz Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @sirosen marked it as resolved too early. I'll unresolve.

Copy link
Member

@sirosen sirosen Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my mistake, sorry! I thought the conversation was done and didn't realize the initial suggestion was still pending.

Copy link
Member Author

@webknjaz webknjaz Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't want to rush with discussions ongoing + other efforts being prioritized.

Copy link
Member Author

@webknjaz webknjaz Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't want to rush with discussions ongoing + other efforts being prioritized.

]
testing = [
"pytest >= 7.2.0",
"pytest-rerunfailures",
Expand Down
2 changes: 2 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ skip_missing_interpreters = True
[testenv]
description = run the tests with pytest
extras =
pipsupported: supported-pip
piplowest: supported-pip
testing
coverage: coverage
deps =
Expand Down
Loading