Fixing issue 693: Avoid simple caches#702
Merged
stokpop merged 3 commits intojborgers:pmd7from Apr 16, 2026
Merged
Conversation
- Updated XPath to allow Calendar.getInstance() usage in main methods. - Refined detection logic to focus on inefficient heavyweight object creation. - Resolved conflict with UnresolvedType property descriptors. - Closes jborgers#693
…mance documentation
Collaborator
|
@MohammedGhallab thanks for your PR! We will review it. |
stokpop
requested changes
Apr 16, 2026
Collaborator
stokpop
left a comment
stokpop
left a comment
There was a problem hiding this comment.
Sorry for the delay. Looks good to me. One request.
|
jborgers
approved these changes
Apr 16, 2026
Owner
jborgers
left a comment
jborgers
left a comment
There was a problem hiding this comment.
Looking good, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "fix(rules): reduce false positives in AvoidCalendarDateCreation"
and fixing issue 693