Open
Conversation
added 3 commits
April 12, 2021 21:06
Collaborator
|
I think what you are seeing is due to the fact that this was originally designed to work with python 2, not python 3. I don't think that it would be wise to make changes that break python 2 support. |
Author
|
Python 2 was sunset a while ago, although I think a simple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change 1 (fix imports)
On trying to import:
I got this error:
Which was fixed by adding '
melopy.' to the start of each melopy import.Change 2 (fix tests)
The tests were still failing, I think this is because
key_to_notewas expecting integer division with/. I have changed this to//and the tests pass (and the results make sense). Additionally, had to movetests/melopy_tests.pyto top level (called ittests.py).Change 3 (fix readme)
Fixes #63
Change 4
Added
__future__statements to make compatible with Python 2.Thanks.