Fix g_n year alignment in pop-growth plots and the fit table#42
Merged
Merged
Conversation
This was referenced Jun 24, 2026
jdebacker
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on
prepop. The reindex moved the pre-TP boundary growth out ofg_nintog_n_preTP, and the model code (aggregates,fiscal,utils) was updated to match — but three display spots that readg_nweren't, so they're off by a year now. Doesn't touch the solution, just what's plotted and reported.plot_pop_growth/plot_g_n: prependg_n_preTPso each rate lines up with its year again.model_fit_table"Pop growth rate": useg_n_preTPat t=0 (g_n[t-1]after) to stay aligned with theomega[t]moments next to it.ruff clean; plot and table tests pass.
cc @jdebacker