forked from gnolang/gno
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(boards2): refactor realm to use gno.land/p/gnoland/boards
#1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jeronimoalbi
wants to merge
22
commits into
feat/boards-package
Choose a base branch
from
refactor/boards2-use-boards-package
base: feat/boards-package
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(boards2): refactor realm to use gno.land/p/gnoland/boards
#1
jeronimoalbi
wants to merge
22
commits into
feat/boards-package
from
refactor/boards2-use-boards-package
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to be able to use `gno.land/p/gnoland/boards` package. Render code can eventually be improved potentially by introducing a render pattern to make rendering flexible.
This refactor removes basic types from the realm in favor of using types from `gno.land/p/gnoland/boards` package.
Some of the functions were not using `WithPermission` for simplicity, but using it is necessary to give flexibility to boards when using custom permissions implementations. This way it's possible to better customize independent boards behavior.
Order changed to better group arguments by type and save horizontal space.
Freezing replies makes no sense.
gno.land/p/gnoland/boardsgno.land/p/gnoland/boards
This package contains a custom CommonDAO member storage that makes it easier and cheaper to boards2 cuatom permissions implementation to integrate with CommonDAO. The custom storage allows using groups to organize roles. It allows saving board members into groups and at the same time automatically add/remove them to a "parent" storage to simplify and improve the basic permissions implementation.
This allows devs to directly modify dao members without going though the basic permissions type to update users.
Owner
Author
|
cc @salmad3 |
This allows any member to leave a board.
…ctor/boards2-use-boards-package
…orage' into refactor/boards2-use-boards-package
…er-package' into refactor/boards2-use-boards-package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary PR for visibility.
A new PR will contain these changes once the following PRs are merged: