Fixes #13962 - HTTP/2 Client connection timeout does not work.

[sbordet]

The problem was that ALPNClientConnection, which is set up when using a HttpClientTransportDynamic with h1 and h2, does not properly override onIdleExpired().

Fixed by overriding onIdleExpired() and failing the connection promise, so that the error is reported to the application.

[olamy]

failing for me locally as well

[INFO] 
[ERROR] Failures: 
[ERROR] org.eclipse.jetty.test.client.transport.HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections(String, String)[2]
[ERROR]   Run 1: HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections:822 Unexpected exception type thrown, expected: <java.util.concurrent.TimeoutException> but was: <java.util.concurrent.ExecutionException>
[ERROR]   Run 2: HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections:822 Unexpected exception type thrown, expected: <java.util.concurrent.TimeoutException> but was: <java.util.concurrent.ExecutionException>
[INFO] 
[ERROR] org.eclipse.jetty.test.client.transport.HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections(String, String)[5]
[ERROR]   Run 1: HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections:822 Unexpected exception type thrown, expected: <java.util.concurrent.TimeoutException> but was: <java.util.concurrent.ExecutionException>
[ERROR]   Run 2: HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections:822 Unexpected exception type thrown, expected: <java.util.concurrent.TimeoutException> but was: <java.util.concurrent.ExecutionException>
[INFO] 
[ERROR] org.eclipse.jetty.test.client.transport.HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections(String, String)[6]
[ERROR]   Run 1: HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections:822 Unexpected exception type thrown, expected: <java.util.concurrent.TimeoutException> but was: <java.util.concurrent.ExecutionException>
[ERROR]   Run 2: HttpClientTransportDynamicTest.testServerDoesNotAcceptConnections:822 Unexpected exception type thrown, expected: <java.util.concurrent.TimeoutException> but was: <java.util.concurrent.ExecutionException>
[INFO] 
[WARNING] Flakes: 
[WARNING] org.eclipse.jetty.test.client.transport.HttpClientLoadTest.testConcurrent(TransportType)[5]
[ERROR]   Run 1: HttpClientLoadTest.testConcurrent:91
[INFO]   Run 2: PASS
[INFO] 
[INFO] 
[ERROR] Tests run: 976, Failures: 3, Errors: 0, Skipped: 18, Flakes: 1
[INFO] 

[olamy]

this is happening only with h2 test

jetty.project/jetty-core/jetty-client/src/main/java/org/eclipse/jetty/client/transport/HttpRequest.java

Line 746 in cc986ad

if (x.getCause() instanceof TimeoutException t)

In the case of h2, the cause is java.net.ConnectException

Easy fix would be to add if else instance of java.net.ConnectException but is it correct?

[lorban]

@olamy this wouldn't help. For some yet unknown reason, this test is flaky but the code change looks good.

[lorban]

@olamy we need to figure out why this test regularly fails in CI and your environment while it doesn't in mine.

I'm 99% sure the problem is in the test itself, but without being able to reproduce it, there isn't much I can do.