Fix flaky ResourceServletTest.testSingleLastWrite()
#14019
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludovic Orban <[email protected]>
Contributor
Author
|
@lachlan-roberts While you're reviewing this, please be aware that CI build #1 failed because the following test looks flaky too: |
gregw
previously approved these changes
Nov 12, 2025
lachlan-roberts
requested changes
Nov 14, 2025
Contributor
lachlan-roberts
left a comment
lachlan-roberts
left a comment
There was a problem hiding this comment.
We should fix in the EE11 ResourceServletTest as well.
...e10/jetty-ee10-servlet/src/test/java/org/eclipse/jetty/ee10/servlet/ResourceServletTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <[email protected]>
Contributor
Author
|
@lachlan-roberts of course I missed EE11! Thanks for catching this, this is now done too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last write can happen after all the response bytes have been written and reached the client, so a timed assertion has to be used.