Repository navigation
build(deps-dev): move workbox-build to glob 14 to clear the minimatch alert - #52
Merged
Merged
Conversation
… alert minimatch 10.2.5 (GHSA-g3hv-75wg-m249, fixed in 11.0.1) reaches the lockfile only through vite-plugin-pwa > workbox-build > glob 11.1.0. No released parent allows the fix: workbox-build 7.4.1 is the latest release and declares glob ^11.0.1, every glob 11 to 13 release requires minimatch ^10, and vite-plugin-pwa 2.0.0 still requires workbox-build ^7.4.1. Override glob to ^14.0.4 for workbox-build only, in pnpm-workspace.yaml, where pnpm 11 and later still read overrides. glob 14 is the first major built on minimatch 11. Forcing minimatch 11 under glob 11 instead has been reported to empty the precache manifest on Linux, because glob 11 still expects RegExp pattern parts. workbox-build calls only globSync(pattern, { cwd, follow, ignore }), which glob 14 keeps. On a local Windows build, dist/ is byte-identical before and after, sw.js included (12 precache entries). The override can go once a workbox-build release accepts glob 14. glob 14.0.4 also clears GHSA-3g3m-2fjr-6pw4. deepmerge 4.3.1 (GHSA-gcqx-w48m-w2h4) stays: it has no patched release, and @rollup/plugin-node-resolve 16.0.3, the latest, declares deepmerge ^4.2.2.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-red2-jq-pointer-jq-pointer.jishnuteegala.workers.dev (commit 11ff6a8)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears the open minimatch Dependabot alert by giving workbox-build glob 14, the first glob major built on the fixed minimatch 11.
No released parent allows the fix, so this adds one scoped pnpm override in a new
pnpm-workspace.yaml;package.jsonis unchanged.This is the same change as cronsense #39 and glasspick #34.
workbox-build>glob: ^14.0.4(glob 14.0.4 requires minimatch^11.0.5)^4.2.2; pathvite-plugin-pwa > workbox-build > @rollup/plugin-node-resolve > deepmergeWhy an override and not a parent upgrade:
glob ^11.0.1.^10; glob 14.0.0 is the first on minimatch^11, and 14.0.4 also clears glob GHSA-3g3m-2fjr-6pw4 (<= 14.0.1).workbox-build ^7.4.1, so upgrading it does not help.globSync(pattern, { cwd, follow, ignore })with its defaultglobIgnores(**/node_modules/**/*), which glob 14 keeps; jq-pointer passes noworkboxoptions.pnpm-workspace.yamlbecause pnpm 11 and later no longer read thepnpmfield ofpackage.json; pnpm 10.34.4 (packageManager) reads it too.No Dependabot PR is open for these alerts (Dependabot could not raise one), so this PR supersedes none.
Evidence
Before: Dependabot security update for minimatch on
mainfailed withsecurity_update_not_possible: run 42678533465 (2026-11-09, "npm_and_yarn in /. for minimatch"), which ranpnpm update minimatch@11.0.5and logged "The latest possible version of minimatch that can be installed is 5.1.9".gh api "repos/jishnuteegala/jq-pointer/dependabot/alerts?state=open"lists alerts 28 (minimatch) and 26 (deepmerge).pnpm auditonmain: deepmerge GHSA-gcqx-w48m-w2h4, glob GHSA-3g3m-2fjr-6pw4 (11.1.0) and minimatch GHSA-g3hv-75wg-m249 (10.2.5).After:
pnpm-lock.yamlresolves one glob (14.0.4) and minimatch 11.0.5 under it; the other minimatch (5.1.9 via filelist) is outside the alert range (>= 7.0.0).pnpm audit: only deepmerge GHSA-gcqx-w48m-w2h4 remains.pnpm install --frozen-lockfilepnpm checktsc -b --noEmit, vitest 209 passed and 10 skipped (jq oracle tests skip on win32 by design)pnpm buildPWA v1.3.0,precache 12 entries (244.01 KiB), same asmaindist/SHA-256 manifest,mainbuild vs branch buildsw.jsincludedcheck:privacy, 4test -f dist/..., deterministic snapshot,sha256sum --check)jq-pointer-snapshot.zip: OK,jq-pointer-snapshot.tar.gz: OKpnpm benchPR CI: all checks green on 11ff6a8.
CI pull_request run 42710646462 (success):
check / App checks (ubuntu-latest)94 s, whose Linux build logsPWA v1.3.0andprecache 12 entries (244.01 KiB)(same count as themainbuild), vitest 20 files and 245 tests passed (jq oracle tests included), "Privacy check passed",jq-pointer-snapshot.zip: OK,jq-pointer-snapshot.tar.gz: OK;check / Conventional commits5 s.CI push run 42710630773 on the same head (success) logs the same precache line and 20 test files passed.
CodeQL run 42710638704 (Analyze actions, javascript-typescript, python) passed, and the
Workers Builds: jq-pointerpreview build (9b5688fb-ab29-44c6-b764-6af6838a6d3c) passed.The push run is within the baseline range; the pull_request run is 3 s above the baseline maximum, and the gap is in the vitest run (69.5 s), not in the build, which this change touches.
Not verified locally: a Linux build (no local Linux environment); the ubuntu CI run above is the Linux evidence. The site was not driven in a browser; runtime code is unchanged.
Merge Danger
Door: two-way
Lockfile and pnpm config only; revert the squash commit to roll back.
Blast Radius: small
glob runs only at build time, when workbox-build lists the files to precache.
A glob behaviour change would show as a different precache list in
sw.js; the local build output is byte-identical and the ubuntu CI build reports the same 12 entries.The merge redeploys the site through Cloudflare Workers Builds; runtime code is unchanged.
Dispositions
globIgnoresmeans glob 14's ignore handling does run; suggested a non-empty precache guard in CIci(...)change); reviewer stood downFINDINGS: 0Review receipt: independent reviewer, 2 rounds (round 1: 1 should-fix; round 2: 0 findings).
Steps: diff review against the alerts and parent ranges; reviewer re-ran install, check, build,
dist/hash comparison and audit in detached worktrees and checked pnpm 10.34.4 reads the override; browser verification skipped, no runtime code changed.