Skip to content

build(deps-dev): move workbox-build to glob 14 to clear the minimatch alert - #52

Merged
jishnuteegala merged 1 commit into
mainfrom
fix/red2-jq-pointer
Nov 9, 2026
Merged

jishnuteegala merged 1 commit into
mainfrom
fix/red2-jq-pointer

Conversation

@jishnuteegala

@jishnuteegala jishnuteegala commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Summary

Clears the open minimatch Dependabot alert by giving workbox-build glob 14, the first glob major built on the fixed minimatch 11.
No released parent allows the fix, so this adds one scoped pnpm override in a new pnpm-workspace.yaml; package.json is unchanged.
This is the same change as cronsense #39 and glasspick #34.

 vite-plugin-pwa 1.3.0 (dev)
   workbox-build 7.4.1          latest release, declares glob ^11.0.1
-    glob 11.1.0                (GHSA-3g3m-2fjr-6pw4)
-      minimatch 10.2.5         (GHSA-g3hv-75wg-m249, alert 28)
+    glob 14.0.4                override workbox-build>glob: ^14.0.4
+      minimatch 11.0.5
     @rollup/plugin-node-resolve 16.0.3
       deepmerge 4.3.1          (GHSA-gcqx-w48m-w2h4, alert 26, no patched release)
Alert Package Advisory Fixed in On this branch How
28 minimatch GHSA-g3hv-75wg-m249 (medium) 11.0.1 11.0.5 override workbox-build>glob: ^14.0.4 (glob 14.0.4 requires minimatch ^11.0.5)
26 deepmerge GHSA-gcqx-w48m-w2h4 (low) none 4.3.1 (residual) not fixable: deepmerge 4.3.1 is the latest release, and @rollup/plugin-node-resolve 16.0.3 (latest) declares ^4.2.2; path vite-plugin-pwa > workbox-build > @rollup/plugin-node-resolve > deepmerge

Why an override and not a parent upgrade:

  • workbox-build 7.4.1 is the latest release and declares glob ^11.0.1.
  • Every glob 11.x to 13.x release requires minimatch ^10; glob 14.0.0 is the first on minimatch ^11, and 14.0.4 also clears glob GHSA-3g3m-2fjr-6pw4 (<= 14.0.1).
  • vite-plugin-pwa 2.0.0 (latest) still requires workbox-build ^7.4.1, so upgrading it does not help.
  • Forcing minimatch 11 under glob 11 is not safe: [workbox-build] Forcing minimatch 11 under glob 11 produces an empty precache manifest on Linux GoogleChrome/workbox#3594 reports it empties the precache manifest on Linux, because glob 11 expects RegExp pattern parts.
  • workbox-build calls glob only as globSync(pattern, { cwd, follow, ignore }) with its default globIgnores (**/node_modules/**/*), which glob 14 keeps; jq-pointer passes no workbox options.
  • The override goes once a workbox-build release accepts glob 14 (Chore/update published dependencies GoogleChrome/workbox#3604, open); the YAML comment says so.
  • It lives in pnpm-workspace.yaml because pnpm 11 and later no longer read the pnpm field of package.json; pnpm 10.34.4 (packageManager) reads it too.

No Dependabot PR is open for these alerts (Dependabot could not raise one), so this PR supersedes none.

Evidence

  • Before: Dependabot security update for minimatch on main failed with security_update_not_possible: run 42678533465 (2026-11-09, "npm_and_yarn in /. for minimatch"), which ran pnpm update minimatch@11.0.5 and logged "The latest possible version of minimatch that can be installed is 5.1.9".
    gh api "repos/jishnuteegala/jq-pointer/dependabot/alerts?state=open" lists alerts 28 (minimatch) and 26 (deepmerge).
    pnpm audit on main: deepmerge GHSA-gcqx-w48m-w2h4, glob GHSA-3g3m-2fjr-6pw4 (11.1.0) and minimatch GHSA-g3hv-75wg-m249 (10.2.5).

  • After: pnpm-lock.yaml resolves one glob (14.0.4) and minimatch 11.0.5 under it; the other minimatch (5.1.9 via filelist) is outside the alert range (>= 7.0.0).
    pnpm audit: only deepmerge GHSA-gcqx-w48m-w2h4 remains.

    Local check on the branch head (Windows) Result
    pnpm install --frozen-lockfile exit 0, lockfile up to date
    pnpm check exit 0: oxlint 0 warnings and 0 errors, oxfmt clean, tsc -b --noEmit, vitest 209 passed and 10 skipped (jq oracle tests skip on win32 by design)
    pnpm build exit 0, PWA v1.3.0, precache 12 entries (244.01 KiB), same as main
    dist/ SHA-256 manifest, main build vs branch build identical, 16 files, sw.js included
    CI post-check (check:privacy, 4 test -f dist/..., deterministic snapshot, sha256sum --check) exit 0, jq-pointer-snapshot.zip: OK, jq-pointer-snapshot.tar.gz: OK
    pnpm bench exit 0, click pipeline p95 69 ms (budget 100 ms)

    PR CI: all checks green on 11ff6a8.
    CI pull_request run 42710646462 (success): check / App checks (ubuntu-latest) 94 s, whose Linux build logs PWA v1.3.0 and precache 12 entries (244.01 KiB) (same count as the main build), vitest 20 files and 245 tests passed (jq oracle tests included), "Privacy check passed", jq-pointer-snapshot.zip: OK, jq-pointer-snapshot.tar.gz: OK; check / Conventional commits 5 s.
    CI push run 42710630773 on the same head (success) logs the same precache line and 20 test files passed.
    CodeQL run 42710638704 (Analyze actions, javascript-typescript, python) passed, and the Workers Builds: jq-pointer preview build (9b5688fb-ab29-44c6-b764-6af6838a6d3c) passed.

    CI timing Wall (s) App checks ubuntu (s)
    Baseline, CI runs, median of 10 78 (39 to 94) 74 (queue 2, setup 14, run 58, post 2.5)
    This PR, pull_request run 42710646462 97 94 (queue 2, setup 9, run 81, post 4)
    This PR, push run 42710630773 81 78 (queue 2, setup 9, run 64, post 5)

    The push run is within the baseline range; the pull_request run is 3 s above the baseline maximum, and the gap is in the vitest run (69.5 s), not in the build, which this change touches.

  • Not verified locally: a Linux build (no local Linux environment); the ubuntu CI run above is the Linux evidence. The site was not driven in a browser; runtime code is unchanged.

Merge Danger

Door: two-way

Lockfile and pnpm config only; revert the squash commit to roll back.

Blast Radius: small

glob runs only at build time, when workbox-build lists the files to precache.
A glob behaviour change would show as a different precache list in sw.js; the local build output is byte-identical and the ubuntu CI build reports the same 12 entries.
The merge redeploys the site through Cloudflare Workers Builds; runtime code is unchanged.

Dispositions

Round Finding Severity Disposition
1 Linux build not verified; workbox-build's default globIgnores means glob 14's ignore handling does run; suggested a non-empty precache guard in CI should-fix fixed in part: the ubuntu CI log's precache count is recorded above, and the same override logged unchanged Linux precache counts in cronsense #39 and glasspick #34; guard refuted for this PR (one dev-dependency concern, CI uses the shared reusable workflow, so a guard is a separate ci(...) change); reviewer stood down
2 none - clean round, FINDINGS: 0

Review receipt: independent reviewer, 2 rounds (round 1: 1 should-fix; round 2: 0 findings).
Steps: diff review against the alerts and parent ranges; reviewer re-ran install, check, build, dist/ hash comparison and audit in detached worktrees and checked pnpm 10.34.4 reads the override; browser verification skipped, no runtime code changed.

… alert

minimatch 10.2.5 (GHSA-g3hv-75wg-m249, fixed in 11.0.1) reaches the
lockfile only through vite-plugin-pwa > workbox-build > glob 11.1.0.
No released parent allows the fix: workbox-build 7.4.1 is the latest
release and declares glob ^11.0.1, every glob 11 to 13 release
requires minimatch ^10, and vite-plugin-pwa 2.0.0 still requires
workbox-build ^7.4.1.

Override glob to ^14.0.4 for workbox-build only, in
pnpm-workspace.yaml, where pnpm 11 and later still read overrides.
glob 14 is the first major built on minimatch 11. Forcing minimatch 11
under glob 11 instead has been reported to empty the precache manifest
on Linux, because glob 11 still expects RegExp pattern parts.
workbox-build calls only globSync(pattern, { cwd, follow, ignore }),
which glob 14 keeps.

On a local Windows build, dist/ is byte-identical before and after,
sw.js included (12 precache entries). The override can go once a
workbox-build release accepts glob 14. glob 14.0.4 also clears
GHSA-3g3m-2fjr-6pw4.

deepmerge 4.3.1 (GHSA-gcqx-w48m-w2h4) stays: it has no patched
release, and @rollup/plugin-node-resolve 16.0.3, the latest, declares
deepmerge ^4.2.2.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-red2-jq-pointer-jq-pointer.jishnuteegala.workers.dev (commit 11ff6a8)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://05a94e4d-jq-pointer.jishnuteegala.workers.dev 11ff6a8 2026-11-09T22:18:50.958Z Visit the dashboard ↗

@jishnuteegala
jishnuteegala merged commit dac0e54 into main Nov 9, 2026
9 checks passed
@jishnuteegala
jishnuteegala deleted the fix/red2-jq-pointer branch November 9, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant