Skip to content

Conversation

@ikoolik
Copy link

@ikoolik ikoolik commented Feb 6, 2019

Issue #48

In src/utils/emoji-index/nimble-emoji-index.js line 7, we assign the return value of the uncompress(data) call to the data variable. But the named function has no return value.

Because of this, the headless search is not functional. This quick fix should fix the issue.

@4ver
Copy link

4ver commented Feb 6, 2019

Just to note, the return was removed recently in this pr #42

@ikoolik
Copy link
Author

ikoolik commented Feb 6, 2019

I just found another PR #45 that also addresses the same issue but from a different angle (sorry, should've checked before creating my own)

Merging either #45 or #49 should fix the bug.

@uniibu
Copy link

uniibu commented Mar 2, 2019

Imo, PR #45 would be better approach than this as the data object is already mutated thus returning it will make no sense and will just add extra overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants