Improve Edge send-only compatibility handling - #139
Open
insane66613 wants to merge 1 commit into
Open
insane66613 wants to merge 1 commit into
insane66613 wants to merge 1 commit into
Conversation
Port the patched 1.9.3 extension changes, improve cross-context handling and diagnostics, skip unsupported legacy cloud-push tests in Edge, hide sensitive token output, and provide a local send-only device name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Microsoft Edge compatibility handling for the Join Chrome extension while preserving existing Chrome behavior.
It is not intended to make Edge a full Join cloud-push receiver. Edge does not provide the legacy Chrome extension receiver APIs used by Join's current browser receiver path (
chrome.gcm/chrome.instanceID). A true Edge receiver would require a different Web Push/FCM registration and delivery path, including backend compatibility.Instead, this PR makes unsupported receiver capability degrade more cleanly and adds clearer send-only behavior for browsers that cannot register as full cloud-push receivers.
Key changes
Important limitation
This PR does not implement a replacement receiver transport for Edge. Join's existing browser receiver implementation depends on Chrome-specific legacy APIs. The safe scope here is compatibility hardening and send-only fallback, not full Edge receive support.
Validation
Repository has no package.json/CI test runner. Local validation performed:
Manual browser validation is still recommended before merge: