Skip to content

Check for supported events first, send SND_BELL as fallback #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bastian-Krause wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check for supported events first, send SND_BELL as fallback #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c028a
beep: check for supported events before sending SND_TONE
Bastian-Krause Mar 4, 2020
a75d991
beep: support SND_BELL as fallback
Bastian-Krause Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions beep.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,17 +106,29 @@ void do_beep(int freq) {
perror("ioctl");
}
} else {
/* BEEP_TYPE_EVDEV */
struct input_event e;

e.type = EV_SND;
e.code = SND_TONE;
e.value = freq;
/* BEEP_TYPE_EVDEV */
struct input_event e;
unsigned long evbit = 0;

e.type = EV_SND;

/* check supported events and act accordingly */
ioctl(console_fd, EVIOCGBIT(EV_SND, sizeof(evbit)), &evbit);
if(evbit & (1 << SND_TONE)) {
e.code = SND_TONE;
e.value = freq;
} else if(evbit & (1 << SND_BELL)) {
e.code = SND_BELL;
e.value = (freq != 0);
} else {
perror("no supported event type");
return;
}

if(write(console_fd, &e, sizeof(struct input_event)) < 0) {
putchar('\a'); /* See above */
perror("write");
}
if(write(console_fd, &e, sizeof(struct input_event)) < 0) {
putchar('\a'); /* See above */
perror("write");
}
}
}

Expand Down