Skip to content

Fix PHP 8.5 deprecations #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnbillion merged 3 commits into from
Aug 24, 2025
Merged

Fix PHP 8.5 deprecations #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7c1f7c
Fix PHP 8.5 deprecations
Pross Aug 22, 2025
f9eda61
Fix phpcs
Pross Aug 22, 2025
44db394
Add testing on PHP 8.5.
johnbillion Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/acceptance-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ jobs:
- '8.3'
- '7.4'
include:
# Latest WordPress on PHP 8.5
- wp: '6.8'
php: '8.5'
# Latest WordPress on PHP 8.4
- wp: '6.8'
php: '8.4'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
label:
- 'PHP'
php:
- '8.5'
- '8.4'
fail-fast: false
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ jobs:
- '8.3'
- '7.4'
include:
# Latest WordPress on PHP 8.5
- wp: '6.8'
php: '8.5'
# Latest WordPress on PHP 8.4
- wp: '6.8'
php: '8.4'
Expand Down
12 changes: 6 additions & 6 deletions classes/Collector_Assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,13 +283,13 @@ protected static function get_script_modules(): ?array {
$reflector = new ReflectionClass( $modules );

$get_marked_for_enqueue = $reflector->getMethod( 'get_marked_for_enqueue' );
$get_marked_for_enqueue->setAccessible( true );
( \PHP_VERSION_ID < 80100 ) && $get_marked_for_enqueue->setAccessible( true );

$get_dependencies = $reflector->getMethod( 'get_dependencies' );
$get_dependencies->setAccessible( true );
( \PHP_VERSION_ID < 80100 ) && $get_dependencies->setAccessible( true );

$get_src = $reflector->getMethod( 'get_src' );
$get_src->setAccessible( true );
( \PHP_VERSION_ID < 80100 ) && $get_src->setAccessible( true );

/**
* @var array<string, array<string, mixed>> $enqueued
Expand Down Expand Up @@ -365,9 +365,9 @@ protected static function get_script_modules(): ?array {
}

// @todo check isPrivate before changing visibility back
$get_marked_for_enqueue->setAccessible( false );
$get_dependencies->setAccessible( false );
$get_src->setAccessible( false );
( \PHP_VERSION_ID < 80100 ) && $get_marked_for_enqueue->setAccessible( false );
( \PHP_VERSION_ID < 80100 ) && $get_dependencies->setAccessible( false );
( \PHP_VERSION_ID < 80100 ) && $get_src->setAccessible( false );

return $sources;
}
Expand Down
Loading