Skip to content

Conversation

@m3g4p0p
Copy link

@m3g4p0p m3g4p0p commented Jul 28, 2017

Hi there,

we had a situation where an extension would render a specific product based on the (real) URL, and set the og-tags accordingly in the beforeHeaderCreation slot. This was working fine until you added another querystring parameter that was not captured by the cHash; then the og-tags from the last "valid" URL were taken. We solved this by overriding page.669 with a USER_INT, and thought it would be a good idea to make this the default behaviour.

Anyway if you think this is not appropriate performance-wise, I might open an issue instead -- maybe we could find a more convenient way to make this configurable. :-)

All the best
Sebastian

@jonathanheilmann
Copy link
Owner

Hi,
sorry for my delayed answer.
In my opinion, most environments will benefit from cached, and thus faster, og-tag generation.
I'd prefer to add a documentation section with a advice, that it's required to replace USER by USER_INT in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants