Skip to content

Fix issue related with weird app behaves on iPad #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MNiemiec-ios wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix issue related with weird app behaves on iPad #679

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec11d0d
Fix issue related with weird app behaves on iPad
MNiemiec-ios Jun 18, 2021
e475bde
Update modalPresentationStyle
MNiemiec-ios Jun 22, 2021
b0fcd22
Update modalPresentationStyle
MNiemiec-ios Jun 22, 2021
0743309
Update modalPresentationStyle
MNiemiec-ios Jun 22, 2021
1e7b6b7
Update modalPresentationStyle
MNiemiec-ios Jul 14, 2021
dfd5c14
Update modalPresentationStyle
MNiemiec-ios Jul 15, 2021
85eb297
fix: isiPad
Skornos Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Pod/Classes/SideMenuNavigationController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,12 @@ private extension SideMenuNavigationController {
}

func setup() {
modalPresentationStyle = .overFullScreen

if #available(iOS 13.0, *) {
modalPresentationStyle = isiPad ? .automatic : .overFullScreen
} else {
modalPresentationStyle = isiPad ? .overCurrentContext : .overFullScreen
}

setupBlur()
if #available(iOS 13.0, *) {} else {
registerForNotifications()
Expand Down Expand Up @@ -654,3 +658,11 @@ private extension SideMenuNavigationController {
return -presentFactor
}
}

extension UIResponder {
var isiPad: Bool {
get {
UIDevice.current.userInterfaceIdiom == UIUserInterfaceIdiom.pad
}
}
}