Add instancecheck_str__ to _JustMeta for custom beartype error messages#593
Open
Aniketsy wants to merge 4 commits into
Open
Add instancecheck_str__ to _JustMeta for custom beartype error messages#593Aniketsy wants to merge 4 commits into
instancecheck_str__ to _JustMeta for custom beartype error messages#593Aniketsy wants to merge 4 commits into
Conversation
Contributor
|
jorenham
reviewed
May 11, 2026
jorenham
requested changes
May 11, 2026
jorenham
left a comment
jorenham
left a comment
Owner
There was a problem hiding this comment.
I'm not sure how, but we should also figure out a way to test that this actually works.
Contributor
Author
hmm, i'll look into this to test |
Contributor
Author
|
should we add ignore comment to fix these ci-fails ? |
Owner
The error is intentional, so yes. |
Aniketsy
commented
May 25, 2026
Signed-off-by: Aniket <148300120+Aniketsy@users.noreply.github.com>
Aniketsy
commented
May 25, 2026
Signed-off-by: Aniket <148300120+Aniketsy@users.noreply.github.com>
Contributor
Author
|
Any thoughts on this :) |
jorenham
reviewed
Jul 23, 2026
|
|
||
| with pytest.raises( | ||
| BeartypeCallHintParamViolation, | ||
| match="subclasses are not accepted", |
Owner
There was a problem hiding this comment.
we might as well test the entire exception message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #591
followed the comment, it was quite big, funny and with good explanation (i read it twice to fully understand 😀 )