Added swfFullPathOverride (boolean) #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an option called "swfFullPathOverride", default false. When true, swfPath is treated as the full path to Jplayer.swf, even if it doesn't end with the string ".swf". Useful when loading Jplayer.swf from a CDN with a non-direct url.
Author
|
So, I was starting to implement jPlayer for the site I'm working on, but I noticed that the flash player wasn't loading for me. In the framework I'm working in, all the static content is loaded through a mechanism that doesn't allow me to either give a path to Jplayer.swf or point to it directly. All I have is a URL that will load it. This flag will allow users to specify that swfPath is in fact a full path, so that "/Jplayer.swf" doesn't get appended to the end of swfPath incorrectly. |
Contributor
|
This is generic notification that all users issuing pull requests must sign our CLA before we can consider merging with the jPlayer project. |
Author
|
CLA signed. Any feedback on the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option called "swfFullPathOverride", default false. When true, swfPath is treated as the full path to Jplayer.swf, even if it doesn't end with the string ".swf". Useful when loading Jplayer.swf from a CDN with a non-direct url.