Skip to content

Remove the ACP Legacy12 path for Grok #337

Description

@jsgrrchg

Grok currently uses a separate vendored ACP client primarily to support the legacy models field and session/set_model. Maintaining an entire protocol path for a provider-specific model selector is not worth the complexity.

Move Grok to the shared ACP v1 actor used by other runtimes. When Grok does not expose a modern model configOption, inherit the model configured in the Grok CLI and hide the selector or display Managed by Grok CLI.

Acceptance criteria

  • Grok uses the shared ACP v1 actor.
  • Authentication, prompts, streaming, tools, permissions, diffs, and cancellation continue working.
  • Grok inherits its model from the CLI.
  • The UI handles the missing model selector gracefully.
  • The vendored legacy dependency, Legacy12 actor, converters, and related tests are removed.
  • Existing ACP runtimes have no regressions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions