Skip to content

[codex] Make LSP server pass strict mypy#572

Merged
jsiek merged 1 commit into
mainfrom
codex/issue-506-lsp-server-strict
May 15, 2026
Merged

[codex] Make LSP server pass strict mypy#572
jsiek merged 1 commit into
mainfrom
codex/issue-506-lsp-server-strict

Conversation

@jsiek
Copy link
Copy Markdown
Owner

@jsiek jsiek commented May 15, 2026

Summary

  • type the custom-request parameter helpers in lsp/lsp_server.py
  • reuse helpers for LSP range/workspace-edit payloads
  • add lsp.lsp_server to the strict mypy override block without untyped-decorator enforcement, matching optional pygls behavior in CI

Validation

  • make tests
  • python3 -m pytest test/lsp/test_lsp_server.py
  • python3 -m mypy --strict lsp/lsp_server.py --follow-imports=silent
  • python3 -m mypy .
  • python3 -m ruff check lsp/lsp_server.py pyproject.toml
  • git diff --check

Progresses #506.

@jsiek jsiek force-pushed the codex/issue-506-lsp-server-strict branch from f8c708a to fe5bf4d Compare May 15, 2026 21:07
@jsiek jsiek marked this pull request as ready for review May 15, 2026 21:16
@jsiek jsiek merged commit 4c72585 into main May 15, 2026
7 checks passed
@jsiek jsiek deleted the codex/issue-506-lsp-server-strict branch May 15, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant