Skip to content

Added support for pug regex #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for pug regex #134

wants to merge 1 commit into from

Conversation

@gittycat
Copy link

@gittycat gittycat commented May 29, 2018 •
edited
Loading

Added support for Pug (Jade)

@gittycat gittycat mentioned this pull request May 29, 2018
Open
@pioug
Copy link
Collaborator

pioug commented Apr 10, 2020

Thanks @gittycat for your contribution 🙏 Before merging your PR, I need some clarification because I am also not familiar with Pug 💦

The regexes seems to support this syntax /* @echo FOO */ but that doesn't seem to be a valid comment in Pug. Because the current regex rules seems to respect the syntax of each language, I would prefer to support only //- if that makes sense.

@pioug pioug self-requested a review April 10, 2020 19:07
@gittycat
Copy link
Author

gittycat commented Apr 12, 2020

@pioug Yes, //- seem to be the correct syntax.
This PR is pretty old and I've moved on to other things since then. You're welcome to make any other changes with it. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pioug pioug Awaiting requested review from pioug

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gittycat @pioug