Allow GitHub Actions workflow to run on pull requests from forked repos#279
Merged
Conversation
Collaborator
Author
|
The check is failing because of the newer black version. There are 2 options:
|
Owner
|
Thanks for this PR, @samkit-jain and for raising the question about |
Codecov Report
@@ Coverage Diff @@
## stable #279 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 10 10
Lines 1160 1160
=======================================
Hits 1130 1130
Misses 30 30 Continue to review full report at Codecov.
|
samkit-jain
added a commit
that referenced
this pull request
Oct 1, 2020
In #279 `pull_request_target` was added which is now replaced with just `pull_request`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in #278 that the checks were stuck at "Waiting for status to be reported". This was happening because in our workflow file we had set it to run on all push commits and apparently, that is not enough for the workflow to run on forked repos. This PR attempts to solve that by adding a
pull_request_targetevent trigger so that the workflow is run on PRs raised from forked repos. More information can be found here and here.