Fix: Allow nullptr callback in evaluateJavascript on Linux #1607
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback parameter of WebBrowserComponent::evaluateJavascript has a default value of nullptr. Updated the Linux implementation to handle this case properly by checking if the callback queue is empty before attempting to invoke the callback.
…luationCallback_jassert_fix
…luationCallback_jassert_fix
Member
|
Thank you for reporting. We've added a fix here: f6a81fe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback parameter of WebBrowserComponent::evaluateJavascript has a default value of nullptr. Updated the Linux implementation to handle this case properly by checking if the callback queue is empty before attempting to invoke the callback.
Both Windows and macOS implementations already allow nullptr for the callback parameter. This change makes Linux work the same way.