Skip to content

Conversation

@merwaaan
Copy link
Contributor

Hi @juj

We use MathGeoLib alongside other libraries and recently suffered unexpected compilation errors whose cause took a bit of time to track. In the end, we found out it was actually due to MathGeoLib redefining assume, which broke other dependencies also using this common name (for instance, fmt: https://github.com/fmtlib/fmt/blob/739055ae7b08f8d5dffee9552334ede92e50b17b/include/fmt/format.h#L354)

This commit prefixes assume (as well as assert and mathassert for consistency) with "mgl_" to prevent that issue.
If you prefer, I could use another prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant