Skip to content

fix: do not warn about deprecated labels when listing exporters - #1056

Merged
mangelajo merged 1 commit into
jumpstarter-dev:mainfrom
bennyz:do-not-warn-deprecated
Sep 1, 2026
Merged

fix: do not warn about deprecated labels when listing exporters#1056
mangelajo merged 1 commit into
jumpstarter-dev:mainfrom
bennyz:do-not-warn-deprecated

Conversation

@bennyz

@bennyz bennyz commented Sep 1, 2026

Copy link
Copy Markdown
Member

this is only relevant for explicit selectors

Fixes #1055

this is only relevant for explicit selectors

Fixes jumpstarter-dev#1055

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@bennyz
bennyz force-pushed the do-not-warn-deprecated branch from 055ef68 to 5abbd05 Compare September 1, 2026 11:53
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: e61c7dd8-b702-4fdd-8cfd-39c6616c29f5

📥 Commits

Reviewing files that changed from the base of the PR and between b29c7fc and 5abbd05.

📒 Files selected for processing (2)
  • python/packages/jumpstarter-cli/jumpstarter_cli/get.py
  • python/packages/jumpstarter-cli/jumpstarter_cli/get_test.py
💤 Files with no reviewable changes (2)
  • python/packages/jumpstarter-cli/jumpstarter_cli/get_test.py
  • python/packages/jumpstarter-cli/jumpstarter_cli/get.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The get exporters command no longer prints per-exporter deprecated-label warnings. Tests that checked this warning output were removed.

Changes

Exporter warning behavior

Layer / File(s) Summary
Remove exporter listing warnings
python/packages/jumpstarter-cli/jumpstarter_cli/get.py, python/packages/jumpstarter-cli/jumpstarter_cli/get_test.py
The command now prints exporter data without deprecated-label warnings. Tests for the removed warnings were deleted.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 5abbd

This localized change adjusts deprecated-label warnings for explicit exporter selectors, and no actionable merge-blocking risk remains.

Poem

A rabbit found warnings loud,
It cleared the exporter cloud.
No yellow notes remain,
The list hops out plain,
And tests rest quietly, proud.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that deprecated-label warnings are removed when listing exporters, which matches the primary code change.
Description check ✅ Passed The description identifies the explicit-selector scope and links issue #1055, which is directly related to the changeset.
Linked Issues check ✅ Passed The change stops deprecated-label warnings during jmp get exporters, addressing the noise, log-level suppression, and misleading -n guidance described in issue #1055.
Out of Scope Changes check ✅ Passed The changes are limited to exporter-listing warning behavior and the related tests. No unrelated code changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bennyz
bennyz requested a review from mangelajo September 1, 2026 12:01

@mwperina mwperina left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mangelajo
mangelajo added this pull request to the merge queue Sep 1, 2026
Merged via the queue into jumpstarter-dev:main with commit d509c33 Sep 1, 2026
28 checks passed
@bennyz
bennyz deleted the do-not-warn-deprecated branch September 1, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning about deprecated label is very noisy

3 participants