Generate configuration parameters overview - #5932
Conversation
c73e0df to
14ffed5
Compare
f02ff2f to
3295a99
Compare
There was a problem hiding this comment.
I think we should build this as a fat/shadowed jar to make it easy to put it on the annotation processor classpath. No need to do that now, but let's discuss it.
|
|
||
| dependencies { | ||
| api(platform(projects.junitBom)) | ||
| api(projects.junitPlatformCommons) |
There was a problem hiding this comment.
No, but the way OSGI is setup makes it a requirement for every module.
| tasks { | ||
| compileJava { | ||
| options.compilerArgs.add("-Xlint:-module") // due to qualified exports | ||
| options.compilerArgs.add("-Xlint:-module,-processing") // -module: due to qualified exports, -processing: not all annotations need to be processed |
There was a problem hiding this comment.
What warnings does this emit without -processing?
There was a problem hiding this comment.
Complain about all present annotations that weren't claimed by a processor.
Similar too:
https://stackoverflow.com/questions/69439506/no-processor-claimed-any-of-these-annotations
6c063a1 to
e6ab635
Compare
e6ab635 to
314e8fd
Compare
🚨 TestLens detected 37 failed tests 🚨Here is what you can do:
Test SummaryCI / Build / Linux > :platform-tooling-support-tests:test
CI / Build / Windows > :platform-tooling-support-tests:test
CI / Build / macOS > :platform-tooling-support-tests:test
CI / Cross-Version / OpenJ9 25 > :platform-tooling-support-tests:test
CI / Cross-Version / OpenJDK 26 (ga) > :platform-tooling-support-tests:test
CI / Cross-Version / OpenJDK 26 (leyden) > :platform-tooling-support-tests:test
CI / Cross-Version / OpenJDK 27 (ea) > :platform-tooling-support-tests:test
CI / Cross-Version / OpenJDK 27 (valhalla) > :platform-tooling-support-tests:test
CI / Cross-Version / OpenJDK 28 (ea) > :platform-tooling-support-tests:test
🏷️ Commit: 3b011f7 Test Failures (first 10 of 111)JUnitStartTests > junitRun(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
JUnitStartTests > junitRun(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
JUnitStartTests > junitRun(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
JUnitStartTests > junitRunClass(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
JUnitStartTests > junitRunClass(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
JUnitStartTests > junitRunClass(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
JUnitStartTests > junitRunModule(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
JUnitStartTests > junitRunModule(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
JUnitStartTests > junitRunModule(OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)
ModularCompilationTests > compileAllJUnitModules(Path, OutputFiles) (:platform-tooling-support-tests:test in CI / Build / Linux)Muted Tests (first 20 of 37)Select tests to mute in this pull request:
Reuse successful test results:
Click the checkbox to trigger a rerun:
Learn more about TestLens at testlens.app. |
| compileOnlyApi(libs.jspecify) | ||
|
|
||
| // TODO: Shade, but it's non trivial. | ||
| implementation(libs.jackson.databind) |
There was a problem hiding this comment.
@marcphilipp I'm having my doubts about picking Jackson.
- It is a CVE magnet, so we'd have to backport dependency updates quite frequently. Though not many people would actually use the processor.
- Is overkill for what we need.
- Shading Jackson is quite complicated because of various service descriptors and miscellaneous junk in the jar files.
The spring-boot-configuration-processor` resolves this by copying a minimal json implementation. But that implementation is Apache licensed.
There is https://github.com/stleary/JSON-java but the "vibes" are off. No clear license, calendar based versioning, ect.
See: https://docs.spring.io/spring-boot/specification/configuration-metadata/format.html
Closes: #4330
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations