Skip to content

Support explicitHandler in http2-grpc-protocol-buffers #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skogsbaer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support explicitHandler in http2-grpc-protocol-buffers #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions http2-grpc-protocol-buffers/Text/ProtocolBuffers/GRPC.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ data StreamHandler m (i :: Streaming *) (o :: Streaming *) where
ClientStreamHandler :: (Wire i, Wire o, ReflectDescriptor i, ReflectDescriptor o) => ClientStreamHandler m i o a -> StreamHandler m (StreamOf i) (Single o)
BiDiStreamHandler :: (Wire i, Wire o, ReflectDescriptor i, ReflectDescriptor o) => BiDiStreamHandler m i o a -> StreamHandler m (StreamOf i) (StreamOf o)
GeneralStreamHandler :: (Wire i, Wire o, ReflectDescriptor i, ReflectDescriptor o) => GeneralStreamHandler m i o a b -> StreamHandler m (StreamOf i) (StreamOf o)
ExplicitStreamHandler :: (Wire i, Wire o, ReflectDescriptor i, ReflectDescriptor o) => ExplicitStreamHandler m i o -> StreamHandler m (StreamOf i) (StreamOf o)

instance (MakeHandlers xs a, KnownSymbol methodName) => MakeHandlers (Method methodName i o ': xs) a where
type MakeHandlersResult (Method methodName i o ': xs) a = StreamHandler IO i o -> MakeHandlersResult xs a
Expand All @@ -129,6 +130,7 @@ instance (MakeHandlers xs a, KnownSymbol methodName) => MakeHandlers (Method met
ClientStreamHandler handler -> clientStream method handler
BiDiStreamHandler handler -> bidiStream method handler
GeneralStreamHandler handler -> generalStream method handler
ExplicitStreamHandler handler -> explicitStream method handler
in makeHandlers serviceName (Proxy :: Proxy xs) (acc . (newEntry :))

makeServiceHandlers :: forall methods serviceName. (MakeHandlers methods [ServiceHandler], KnownSymbol serviceName) => Service serviceName methods -> MakeHandlersResult methods [ServiceHandler]
Expand Down
9 changes: 6 additions & 3 deletions stack-8.10.2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ packages:

extra-deps:
- base16-bytestring-1.0.0.0@sha256:0cde0953fa84b8f5214b07f00153197b883f6801f59f3de6da3f62a55992874c,2749
- http2-grpc-types-0.5.0.0@sha256:4d34edc06a48496130f19245817a7cd7ea15c78ac8815570c3795ffc4503cf27,1445
- warp-grpc-0.4.0.1@sha256:3859190e4fa23b944cf93ac691b3cec78c2adf4eaff6a4e8070c89fd17915add,1759
- http2-client-0.10.0.0@sha256:85b8771e9e8d4fd0b4327373ebb4a7bc7f9a293e5d7a7dc581ca4153a841da67,2604
- http2-client-grpc-0.8.0.0@sha256:5bea1edf5fa3572155f55c5b38cfab7063cbde613702898986c26d70bc9f3f9e,1861
- git: https://github.com/factisresearch/http2-grpc-haskell.git
commit: baf8e7cf8c58d9ab6004dedda089bd6492f25393
subdirs:
- 'http2-client-grpc'
- 'http2-grpc-types'
- 'warp-grpc'
Comment on lines +11 to +16
Copy link
Copy Markdown
Collaborator

@tvh tvh Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not depend on a forked version here. Could you try to get the ExplicitHandler changes merged?

Copy link
Copy Markdown
Author

@skogsbaer skogsbaer Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what happens: haskell-grpc-native/http2-grpc-haskell#66


allow-newer: true
resolver: nightly-2020-09-21
9 changes: 6 additions & 3 deletions stack-8.6.2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,13 @@ packages:
- http2-grpc-protocol-buffers/

extra-deps:
- http2-grpc-types-0.5.0.0@sha256:4d34edc06a48496130f19245817a7cd7ea15c78ac8815570c3795ffc4503cf27,1445
- warp-grpc-0.4.0.1@sha256:3859190e4fa23b944cf93ac691b3cec78c2adf4eaff6a4e8070c89fd17915add,1759
- http2-client-0.10.0.0@sha256:85b8771e9e8d4fd0b4327373ebb4a7bc7f9a293e5d7a7dc581ca4153a841da67,2604
- http2-client-grpc-0.8.0.0@sha256:5bea1edf5fa3572155f55c5b38cfab7063cbde613702898986c26d70bc9f3f9e,1861
- git: https://github.com/factisresearch/http2-grpc-haskell.git
commit: baf8e7cf8c58d9ab6004dedda089bd6492f25393
subdirs:
- 'http2-client-grpc'
- 'http2-grpc-types'
- 'warp-grpc'

allow-newer: true
resolver: nightly-2018-11-20
11 changes: 7 additions & 4 deletions stack-8.8.4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@ packages:
- http2-grpc-protocol-buffers/

extra-deps:
- haskell-src-exts-1.22.0@sha256:f558923a9c8f57402c33a8cc871b934027a5c65414404c87239f6cbd7357d54e,4541
- http2-grpc-types-0.5.0.0@sha256:4d34edc06a48496130f19245817a7cd7ea15c78ac8815570c3795ffc4503cf27,1445
- warp-grpc-0.4.0.1@sha256:3859190e4fa23b944cf93ac691b3cec78c2adf4eaff6a4e8070c89fd17915add,1759
- http2-client-0.10.0.0@sha256:85b8771e9e8d4fd0b4327373ebb4a7bc7f9a293e5d7a7dc581ca4153a841da67,2604
- http2-client-grpc-0.8.0.0@sha256:5bea1edf5fa3572155f55c5b38cfab7063cbde613702898986c26d70bc9f3f9e,1861
- haskell-src-exts-1.22.0@sha256:f558923a9c8f57402c33a8cc871b934027a5c65414404c87239f6cbd7357d54e,4541
- git: https://github.com/factisresearch/http2-grpc-haskell.git
commit: baf8e7cf8c58d9ab6004dedda089bd6492f25393
subdirs:
- 'http2-client-grpc'
- 'http2-grpc-types'
- 'warp-grpc'

allow-newer: true
resolver: lts-16.20