e2e: Refactor PF shutdown test case
#962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shutting down a PF to test if the NIC can be used for pod-to-pod connectivity causes a race condition, as the config-daemon would try to set it up again during reconciliation. Also, it would trigger a node drain, making the test case very flaky. Instead, convert the test case to verify that a NIC with no carrier provides intra-node connectivity. Signed-off-by: Andrea Panattoni <[email protected]>
|
Thanks for your PR,
To skip the vendors CIs, Maintainers can use one of:
|
Pull Request Test Coverage Report for Build 19137964106Details
💛 - Coveralls |
adrianchiris
approved these changes
Nov 25, 2025
Collaborator
adrianchiris
left a comment
adrianchiris
left a comment
There was a problem hiding this comment.
so we require to have a nic with cable unplugged for this to actually run.
Member
Author
yes, but if no device is found with such condition, the test is skipped (not failed) |
Collaborator
|
ack, thx for addressing my comments. feel free to merge if you are happy with the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shutting down a PF to test if the NIC can be used for pod-to-pod connectivity causes a race condition, as the config-daemon would try to set it up again during reconciliation. Also, it would trigger a node drain, making the test case very flaky.
Instead, convert the test case to verify that a NIC with
no carrier provides intra-node connectivity.