Repository navigation
workerpool: configure the actor limit per worker - #130
Open
renato0307 wants to merge 1 commit into
Open
renato0307 wants to merge 1 commit into
renato0307 wants to merge 1 commit into
Conversation
I have used AI to implement the code but I reviewed the code myself. Signed-off-by: Renato Torres <renato.torres@outsystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkerPools need to configure the existing worker actor limit, for example three resident actors per worker.
Closes #129.
Adds optional
spec.maxActorsPerWorkerand forwards it to--max-actorsfor gVisor and microVM workers. Omission preserves the worker default. Zero accepts no actors. Negative and out-of-range values fail validation.Changing or removing the field rolls the workers through the existing drain process. The CRD, Helm CRD copy, deepcopy code, and API guide are updated.
Checks:
Full
go test -race ./...failed only in two unchanged microVM child-process tests withunsupported operationon macOS. Live-worker e2e tests were not run.I have used AI to implement the code but I reviewed the code myself.