Experimental rules - #12
Draft
AlbertSmit wants to merge 6 commits into
Draft
AlbertSmit wants to merge 6 commits into
AlbertSmit wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve added three new rules to keep our CSS structured, and cleaned up some internal machinery to support them.
What's added:
no-hardcoded-colors: Walks PostCSS declarations to block raw hex, rgb, rgba, and hsl values in component files. It permits variable definitions (like gradients) and ignores theme/infra files so token setup still works.color-variable-layering: Enforces the 3-layer color setup. At lint-time, it parsesstyle-contexts.cssin the project'scssGlobaldirectory to build an allowlist of context tokens. Any other--color-*variables used in component declarations will be flagged.media-query-convention: Enforces mobile-first design by flaggingmax-widthqueries (unless combined with complex queries like orientation). IfcssGlobalis configured, it parses the project'smedia.js(Object literals) ormedia.css(@custom-media) to validate query breakpoints and flag typos.Internal refactoring:
cssGlobal.js: Isolated the media/breakpoint parsing and test-seeding caches into a newbreakpoints.jsutility, leaving only file-reading and path validation incssGlobal.js.callPlugininkaliber.jsto passsecondaryOptionObjectasoptionsso rules can read configuration (like thecssGlobalpath).