Skip to content

No updates to self.logits with bigram counts in Bigram class #28

Description

@mriganktiwari

Hello everyone, i've made a makemore.py file (same as https://github.com/karpathy/makemore/blob/master/makemore.py) with only Bigram model class as of now.

while running it with python makemore.py -i names.txt -o names --type bigram arguments, wouldn't it just keep training, where it actually isn't doing anything coz there is no operation in forward pass.

Has anyone succesfully run it? Or it is yet to be completed?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions