Skip to content

add path to cachedresource api #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcp-ci-bot merged 1 commit into from
Nov 26, 2025
Merged

add path to cachedresource api #3726

kcp-ci-bot merged 1 commit into from
Nov 26, 2025

Conversation

@olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented Nov 20, 2025 •
edited
Loading

Summary

change implements adds path to the cachedresource api so that a CachedResourceEndpointSlice can reference a `CachedResource` located in another workspace.
image

What Type of PR Is This?

Related Issue(s)

Fixes 3658

Release Notes

Added to path to cachedresource so that CachedResourceEndpointSlice can reference a CachedResource in another workspace

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2025
gman0
gman0 reviewed Nov 21, 2025
View reviewed changes
@gman0
Copy link
Contributor

gman0 commented Nov 21, 2025

Thanks, looks good.

Can you please add an e2e test to cachedresourceendpointslice/ in https://github.com/kcp-dev/kcp/tree/main/test/e2e/reconciler , similar to the one implemented in https://github.com/kcp-dev/kcp/tree/main/test/e2e/reconciler/apiexportendpointslice ?

If you're ok with that, do it only for the path param, and leave partition for now because we might want to change it later.

@olamilekan000 olamilekan000 force-pushed the add-path-to-cachedresourcerefrence-api branch 3 times, most recently from 600f928 to 0caadff Compare November 24, 2025 03:43
@olamilekan000
Copy link
Contributor Author

olamilekan000 commented Nov 24, 2025

/retest

@olamilekan000 olamilekan000 requested a review from gman0 November 24, 2025 06:26
@olamilekan000 olamilekan000 force-pushed the add-path-to-cachedresourcerefrence-api branch from 0caadff to 8398dd7 Compare November 26, 2025 00:05
@olamilekan000 olamilekan000 requested a review from gman0 November 26, 2025 00:06
@gman0
Copy link
Contributor

gman0 commented Nov 26, 2025 •
edited
Loading

Great, thanks!

/lgtm

Actually one more thing.

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Nov 26, 2025

LGTM label has been added.

Git tree hash: 4b563b00694b72bfecb16c662741e839bf42f7e2

@gman0 gman0 removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025
@olamilekan000
add path to cachedresource api
340b8f4 
Signed-off-by: olalekan odukoya <[email protected]>
@olamilekan000 olamilekan000 force-pushed the add-path-to-cachedresourcerefrence-api branch from 8398dd7 to 340b8f4 Compare November 26, 2025 12:08
@gman0
Copy link
Contributor

gman0 commented Nov 26, 2025

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Nov 26, 2025

LGTM label has been added.

Git tree hash: e8a47d85dbe097ffe92f99c4e026cfd46cd414e3

@olamilekan000 olamilekan000 requested a review from gman0 November 26, 2025 12:48
@olamilekan000
Copy link
Contributor Author

olamilekan000 commented Nov 26, 2025

/retest

1 similar comment
@olamilekan000
Copy link
Contributor Author

olamilekan000 commented Nov 26, 2025

/retest

@olamilekan000
Copy link
Contributor Author

olamilekan000 commented Nov 26, 2025

/retest

mjudeikis
mjudeikis approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

As this crd was introduced in this release, better merge now

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@kcp-ci-bot kcp-ci-bot merged commit a6829d3 into kcp-dev:main Nov 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjudeikis mjudeikis mjudeikis approved these changes

@xmudrii xmudrii Awaiting requested review from xmudrii

@gman0 gman0 Awaiting requested review from gman0

Assignees

@gman0 gman0

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: add path to CachedResourceReference API

4 participants

@olamilekan000 @gman0 @kcp-ci-bot @mjudeikis