Fix AppRun path issue

[phoerious]

Fix PATH issue in AppRun script.
Fixes #12612

Changes not actually tested yet.

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[droidmonkey]

I found that the browser integration also does not work anymore (at least with snap firefox). Same browser works with native install.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.35%. Comparing base (964bb59) to head (d2d5f60).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #12643      +/-   ##
===========================================
- Coverage    64.37%   64.35%   -0.02%     
===========================================
  Files          378      378              
  Lines        39823    39823              
===========================================
- Hits         25636    25627       -9     
- Misses       14187    14196       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[phoerious]

Ok, maybe we need to add the library path back as well.

[droidmonkey]

Nah it's the Firefox Snap, it doesn't set the environment variable. Need to include the flatpak method here.

https://github.com/keepassxreboot/keepassxc/blob/develop/utils%2Fkeepassxc-flatpak-wrapper.sh#L26-L34

[phoerious]

But why? We haven't changed that part in years. Are there any other env cars we could check for?

[droidmonkey]

The fix I posted works with Snap Firefox now.

[Copilot]

Pull Request Overview

This PR modifies the AppImage startup script to improve how the application routes execution to the appropriate binary (CLI, proxy, or main GUI). The key changes refactor the browser proxy detection logic and add PATH/LD_LIBRARY_PATH configuration.

• Adds explicit PATH and LD_LIBRARY_PATH exports for AppImage bundled binaries
• Separates the browser proxy detection into a distinct elif clause
• Adds a new condition to detect browser extension invocations via the $2 parameter

[phoerious]

We should ensure we never set an empty : as a library path, otherwise we're back at the issue because of which I removed it in the first place.

[droidmonkey]

Oh take that out then, it is not needed for the proxy