fix: generate UUID for prometheus alerts when id is not a valid uuid#6219
Open
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Open
fix: generate UUID for prometheus alerts when id is not a valid uuid#6219DragonBot00 wants to merge 1 commit intokeephq:mainfrom
DragonBot00 wants to merge 1 commit intokeephq:mainfrom
Conversation
Contributor
Author
|
Hi maintainers, this PR has been open for a day with no review. The fix is a one-line change that resolves #4985 — Prometheus alerts store the alertname string as id instead of a UUID, breaking workflow links. Would appreciate a quick review when you get a chance. Happy to adjust based on feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4985
When Prometheus sends alerts via Alertmanager webhook, the id field contains the alertname string (e.g., HostOomKillDetected) rather than a UUID. This causes 500 errors when clicking alerts in workflow 'Triggered by' links, which expect a valid alert ID.
Changes
How it works
Testing