fix(workflows): sync workflow_raw YAML when toggling disabled state (fixes #5361)#6227
Open
asheesh-devops wants to merge 1 commit intokeephq:mainfrom
Open
Conversation
…ixes keephq#5361) Update the toggle endpoint to also update the 'disabled' key in the stored workflow_raw YAML, keeping the DB field and YAML in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes mismatch between the workflow card's "Disabled" label and the actual YAML
disabledfield when toggling a workflow's enabled/disabled state via the API.Root Cause
In
toggle_workflow_state(), only theis_disabledDB column was updated — the raw YAML stored inworkflow_rawwas never touched. This caused the UI card to show one state while the YAML contained a differentdisabledvalue. There was already aTODOcomment acknowledging this:The Fix
Parse the stored YAML, update the
disabledkey to match the new state, and write it back:This follows the same
cyaml.dump(data, width=99999)pattern used in the workflow update endpoint (line 848).Changes
keep/api/routes/workflows.py— syncworkflow_rawYAML intoggle_workflow_state()Testing
cyaml.safe_load/cyaml.dumpare used throughout the codebase for YAML serializationdisabledfrom YAML viaworkflow_raw_data.get("disabled", False)— this fix ensures round-trip consistencywidth=99999parameter matches existing usage to prevent unwanted line wrappingFixes #5361