Repository navigation
Development improvements #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c33877e
eb96dc1
0fbe45a
1c556c3
25eddca
8fcd8c9
4fb1480
00067aa
63962ff
5eb8005
58cc8db
f3cd256
8c9843b
7c1cd37
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -45,6 +45,12 @@ | |||||||||||||||||||||
| become: true | ||||||||||||||||||||||
| tags: [apt, brave] | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| - name: Import Proton VPN installation tasks | ||||||||||||||||||||||
| ansible.builtin.import_tasks: tasks/apt-release-protonvpn.yml | ||||||||||||||||||||||
| when: (apt.releases.protonvpn | default(false)) if apt.releases is defined else false | ||||||||||||||||||||||
| become: true | ||||||||||||||||||||||
| tags: [apt, protonvpn, vpn] | ||||||||||||||||||||||
|
Comment on lines
+48
to
+52
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Simplify the The current (apt.releases.protonvpn | default(false)) if apt.releases is defined else falseA clearer and more idiomatic alternative is: when: apt.releases is defined and (apt.releases.protonvpn | default(false))This relies on short-circuiting, keeps the logic in standard
Suggested change
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
| - name: Import eget installation tasks | ||||||||||||||||||||||
| ansible.builtin.import_tasks: tasks/eget.yml | ||||||||||||||||||||||
| when: eget | default(false) | bool | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| - name: Download Proton VPN stable release package | ||
| ansible.builtin.get_url: | ||
| url: https://repo.protonvpn.com/debian/dists/stable/main/binary-all/protonvpn-stable-release_1.0.8_all.deb | ||
| dest: /tmp/protonvpn-stable-release_1.0.8_all.deb | ||
|
Comment on lines
+2
to
+5
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Consider parameterizing the Proton VPN release version and download path for maintainability. Both the URL and |
||
| mode: '0644' | ||
|
|
||
| - name: Install Proton VPN repository package | ||
| ansible.builtin.apt: | ||
| deb: /tmp/protonvpn-stable-release_1.0.8_all.deb | ||
| state: present | ||
|
|
||
| - name: Install Proton VPN app | ||
| ansible.builtin.apt: | ||
| name: proton-vpn-gnome-desktop | ||
| state: present | ||
| update_cache: true | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,7 +83,10 @@ | |
| jq: >- | ||
| -a {{ 'linux64' if eget_arch == 'x86_64' else 'linux-arm64' if eget_arch == 'arm64' else 'linux-arm' }} | ||
| jqlang/jq | ||
| oyster: "--tag pearl-wallet-v1.0.0 -a .tar.gz --file oyster --to oyster pearl-research-labs/pearl" | ||
| pandoc: "-a linux-{{ 'amd64' if eget_arch == 'x86_64' else 'arm64' }}.tar.gz jgm/pandoc" | ||
| pearld: "--tag pearl-wallet-v1.0.0 -a .tar.gz --file pearld --to pearld pearl-research-labs/pearl" | ||
| prlctl: "--tag pearl-wallet-v1.0.0 -a .tar.gz --file prlctl --to prlctl pearl-research-labs/pearl" | ||
|
Comment on lines
+86
to
+89
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: Avoid repeating the Pearl wallet version string across multiple eget entries.
Suggested implementation: Define
Ensure the variable name matches exactly ( |
||
| rg: "-a {{ eget_plain_arch }}-unknown-linux-musl.tar.gz BurntSushi/ripgrep" | ||
| tealdeer: "-a tealdeer-linux-{{ eget_arch }}-musl -a ^sha256 dbrgn/tealdeer" | ||
| vale: "-a {{ 'Linux_64-bit' if eget_arch == 'x86_64' else 'Linux_arm64' }}.tar.gz errata-ai/vale" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,3 +16,6 @@ node_modules/ | |
|
|
||
| # Ansible local variables | ||
| .ansible/variables.yml | ||
|
|
||
| # NAS | ||
| .nas_credentials | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| username=admin | ||
| password=YOUR_PASSWORD | ||
| domain= # leave empty or put WORKGROUP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): Consider hyphenating “VPN related” to “VPN-related”.
In this row, update the description to “Runs VPN-related tasks.” to match standard hyphenation and keep the table wording consistent.